Логотип exploitDog
Консоль
Логотип exploitDog

exploitDog

github логотип

GHSA-2xmm-g482-4439

Опубликовано: 15 мар. 2022
Источник: github
Github: Прошло ревью
CVSS3: 9.8

Описание

DQL injection through sorting parameters blocked

Impact

Values added at the end of query sorting were passed directly to the DB. We don't know, if it could lead to direct SQL injections, however, we should not allow for easy injection of values there anyway.

Patches

The issue is fixed in version 1.10.1 and in 1.11-rc.1

Workarounds

You have to overwrite your Sylius\Component\Grid\Sorting\Sorter.php class:

<?php // src/App/Sorting/Sorter.php declare(strict_types=1); namespace App\Sorting; use Symfony\Component\HttpKernel\Exception\BadRequestHttpException; use Sylius\Component\Grid\Data\DataSourceInterface; use Sylius\Component\Grid\Definition\Grid; use Sylius\Component\Grid\Parameters; use Sylius\Component\Grid\Sorting\SorterInterface; final class Sorter implements SorterInterface { public function sort(DataSourceInterface $dataSource, Grid $grid, Parameters $parameters): void { $enabledFields = $grid->getFields(); $expressionBuilder = $dataSource->getExpressionBuilder(); $sorting = $parameters->get('sorting', $grid->getSorting()); $this->validateSortingParams($sorting, $enabledFields); foreach ($sorting as $field => $order) { $this->validateFieldNames($field, $enabledFields); $gridField = $grid->getField($field); $property = $gridField->getSortable(); if (null !== $property) { $expressionBuilder->addOrderBy($property, $order); } } } private function validateSortingParams(array $sorting, array $enabledFields): void { foreach (array_keys($enabledFields) as $key) { if (array_key_exists($key, $sorting) && !in_array($sorting[$key], ['asc', 'desc'])) { throw new BadRequestHttpException(sprintf('%s is not valid, use asc or desc instead.', $sorting[$key])); } } } private function validateFieldNames(string $fieldName, array $enabledFields): void { $enabledFieldsNames = array_keys($enabledFields); if (!in_array($fieldName, $enabledFieldsNames, true)) { throw new BadRequestHttpException(sprintf('%s is not valid field, did you mean one of these: %s?', $fieldName, implode(', ', $enabledFieldsNames))); } } }

and register it in your container:

# config/services.yaml services: # ... sylius.grid.sorter: class: App\Sorting\Sorter

For more information

If you have any questions or comments about this advisory:

Пакеты

Наименование

sylius/grid-bundle

composer
Затронутые версииВерсия исправления

< 1.10.1

1.10.1

EPSS

Процентиль: 68%
0.00558
Низкий

9.8 Critical

CVSS3

Дефекты

CWE-89

Связанные уязвимости

CVSS3: 9.8
nvd
почти 4 года назад

SyliusGridBundle is a package of generic data grids for Symfony applications. Prior to versions 1.10.1 and 1.11-rc2, values added at the end of query sorting were passed directly to the database. The maintainers do not know if this could lead to direct SQL injections but took steps to remediate the vulnerability. The issue is fixed in versions 1.10.1 and 1.11-rc2. As a workaround, overwrite the`Sylius\Component\Grid\Sorting\Sorter.php` class and register it in the container. More information about this workaround is available in the GitHub Security Advisory.

CVSS3: 9.8
fstec
почти 4 года назад

Уязвимость платформы электронной коммерции SyliusGridBundle для приложений Symfony, связанная с непринятием мер по защите структуры запроса SQL, позволяющая нарушителю выполнять произвольные SQL-запросы

EPSS

Процентиль: 68%
0.00558
Низкий

9.8 Critical

CVSS3

Дефекты

CWE-89