GHSA-4852-vrh7-28rf

Опубликовано: 09 июн. 2020

Источник: github

Github: Прошло ревью

CVSS3: 7.4

Описание

Reflected XSS in GraphQL Playground

Impact

directly impacted:

graphql-playground-html@<1.6.22 - all unsanitized user input for renderPlaygroundPage()

all of our consuming packages of graphql-playground-html are impacted:

graphql-playground-middleware-express@<1.7.16 - unsanitized user input to expressPlayground()
graphql-playground-middleware-koa@<1.6.15 - unsanitized user input to koaPlayground()
graphql-playground-middleware-lambda@<1.7.17 - unsanitized user input to lambdaPlayground()
graphql-playground-middleware-hapi@<1.6.13 - unsanitized user input to hapiPlayground()

as well as any other packages that use these methods with unsanitized user input.

not impacted:

graphql-playground-electron - uses renderPlaygroundPage() statically for a webpack build for electron bundle, no dynamic user input
graphql-playground-react - usage of the component directly in a react application does not expose reflected XSS vulnerabilities. only the demo in public/ contains the vulnerability, because it uses an old version of the html pacakge.

Patches

upgrading to the above mentioned versions will solve the issue.

If you're using graphql-playground-html directly, then:

yarn add graphql-playground-html@^1.6.22

npm install --save graphql-playground-html@^1.6.22

Then, similar steps need to be taken for each middleware:

Workarounds

Ensure you properly sanitize all user input for options you use for whatever function to initialize GraphQLPlayground:

for example, with graphql-playground-html and express:

const { sanitizeUrl } = require('@braintree/sanitize-url'); const qs = require('querystringify'); const { renderPlaygroundPage } = require('graphql-playground-html'); module.exports = (req, res, next) => { const { endpoint } = qs.parse(req.url) res.html(renderPlaygroundPage({endpoint: sanitizeUrl(endpoint) })).status(200) next() }

or, with graphql-playground-express:

const { expressPlayground } = require('graphql-playground-middleware-express'); const { sanitizeUrl } = require('@braintree/sanitize-url'); const qs = require('querystringify'); const { renderPlaygroundPage } = require('graphql-playground-html'); module.exports = (req, res, next) => { const { endpoint } = qs.parse(req.url) res.html(expressPlayground({endpoint: sanitizeUrl(endpoint) })).status(200) next() }

References

Credits

Masato Kinugawa of Cure53

For more information

If you have any questions or comments about this advisory:

Open an issue in graphql-playground
Email us at rikki.schulte@gmail.com

Ссылки

Пакеты

Наименование

graphql-playground-html

npm

Затронутые версииВерсия исправления

< 1.6.22

1.6.22

EPSS

Процентиль: 97%

0.33487

Средний

7.4 High

CVSS3

CVE ID

CVE-2020-4038

Дефекты

CWE-79

Связанные уязвимости

CVE-2020-4038

CVSS3: 7.4

nvd

больше 5 лет назад

GraphQL Playground (graphql-playground-html NPM package) before version 1.6.22 have a severe XSS Reflection attack vulnerability. All unsanitized user input passed into renderPlaygroundPage() method could trigger this vulnerability. This has been patched in graphql-playground-html version 1.6.22. Note that some of the associated dependent middleware packages are also affected including but not limited to graphql-playground-middleware-express before version 1.7.16, graphql-playground-middleware-koa before version 1.6.15, graphql-playground-middleware-lambda before version 1.7.17, and graphql-playground-middleware-hapi before 1.6.13.

EPSS

Процентиль: 97%

0.33487

Средний

7.4 High

CVSS3

CVE ID

CVE-2020-4038

Дефекты

CWE-79