GHSA-fqcv-8859-86x2

Описание

SQL Injection in CustomerTransformerController

Summary

An error-based SQL Injection vulnerability was identified in the CustomerTransformerController within the CoreShop admin panel.
The affected endpoint improperly interpolates user-supplied input into a SQL query, leading to database error disclosure and potential data extraction.

This issue is classified as MEDIUM severity, as it allows SQL execution in an authenticated admin context.

Details

The vulnerability exists in the company name duplication check endpoint:

Source code analysis indicates that user input is directly embedded into a SQL condition without parameterization.

Vulnerable file:

Vulnerable code pattern:

The $value parameter is fully user-controlled and is not escaped or bound as a prepared statement parameter.
Supplying a double quote (") causes a SQL syntax error, confirming that the input is executed in a SQL context.

Exploitation Steps:

Prerequisites

• Admin panel access at https://demo4.coreshop.org/admin
• Default credentials: admin / coreshop

Authenticate to admin panel

Trigger SQL error to confirm injection

Expected result: HTTP 500 error page with title "500 | CORS - Pimcore Digital Agency"

Normal response (non-error):

Proof of Impact:

Test 1 - Normal query:

Test 2 - SQL injection (error-inducing):

The double quote character causes a SQL syntax error, confirming the injection point. The application returns a 500 error instead of the normal JSON response, proving that unescaped user input reaches the SQL query.

Sqlmap Result:

Impact

• Vulnerability type: SQL Injection (Error-based)
• Affected users: CoreShop / Pimcore admin users
• Potential impact:
  • Database error disclosure
  • Database schema enumeration
  • Possible data extraction via error-based or blind SQL injection

Recommended Fix

1. Use Parameterized Queries (Required)

Avoid building SQL conditions using string concatenation or sprintf.
Use Doctrine QueryBuilder parameters instead.

❌ Vulnerable example:

✅ Secure example (Doctrine QueryBuilder):

This ensures proper escaping and prevents SQL injection.

2. Validate User Input (Defense-in-Depth)

Apply strict input validation before processing user data:

Optionally, restrict allowed characters if business logic permits.

3. Handle Errors Gracefully

Avoid returning raw 500 error pages to users.
Catch database exceptions and return a controlled JSON error response instead:

4. Security Best Practice

• Never interpolate user input directly into SQL strings
• Always use prepared statements or ORM parameter binding
• Ensure consistent input validation on all admin endpoints