GHSA-m67m-3p5g-cw9j

Описание

Summary

When creating a new component from an existing component that has a source code repository URL specified in settings, this URL is included in the client's URL parameters during the creation process. If, for example, the source code repository URL contains GitHub credentials, the confidential PAT and username are shown in plaintext and get saved into browser history. Moreover, if the request URL is logged, the credentials are written to the logs in plaintext.

The problematic URL in question is of this form:

If using Weblate official Docker image, nginx logs the URL and the token in plaintext:

Reproduction

1. In a project, create a component which has the Repository push URL setting configured with, for example, a GitHub repository URL including a username and a PAT.
2. In the same project, create another component using the From existing component option and selecting the previous component as the source. Click Continue.
3. Observe that the URL parameter repo includes the secret PAT configured in the original components settings. The URL with the token is potentially saved as plaintext in browser history and server logs.
4. Select a translation file to import and click Continue.
5. Observe again the same repo parameter in the URL.

Impact

• If server logs are compromised, the attacker may be able to gain access to private repositories potentially containing sensitive source code.
• Under common browser settings, the URL containing VCS credentials is saved into browser history. Browser extensions, for example, are often able to read the history and thus offer a realistic attack vector to gain access to the credentials.