Описание
Directus's S3 assets become unavailable after a burst of HEAD requests
Summary
There's some tools that use Directus to sync content and assets. Some of those tools use HEAD method, like Shopify, to check the existence of files. Although, when making many HEAD requests at once, at some point, all assets are being served as 403.
Details
When I was investigating this issue, I have found that after the burst of HEAD requests, the amount of sockets held on Agent on NodeHttpHandler was always equal to STORAGE_CLOUD_MAX_SOCKETS making it impossible to have new connections causing assets to be inaccessible.
After looking into this issue on AWS SDK I found that if the stream is requested, it needs to be consumed otherwise will hang forever. And as can be seen here the stream is not consumed.
The timeouts set here had no noticeable effect on tests made.
PoC
This can be easily reproduced with the following steps:
- setup AWS S3 storage
- set STORAGE_CLOUD_MAX_SOCKETS: "50" (this value is lower than default for easier reproduction)
- upload a file to your project
- run this file (Replace the the file ID with the one you just uploaded):
Here's an example:
https://github.com/user-attachments/assets/29d65bf0-5637-478f-a215-083c2ded3753
Impact
This causes denial of assets for all policies of Directus, including Admin and Public.
Пакеты
@directus/storage-driver-s3
>= 9.22.0, < 12.0.1
12.0.1
directus
>= 9.22, < 11.5.0
11.5.0
Связанные уязвимости
Directus is a real-time API and App dashboard for managing SQL database content. The `@directus/storage-driver-s3` package starting in version 9.22.0 and prior to version 12.0.1, corresponding to Directus starting in version 9.22.0 and prior to 11.5.0, is vulnerable to asset unavailability after a burst of HEAD requests. Some tools use Directus to sync content and assets, and some of those tools use the HEAD method to check the existence of files. When making many HEAD requests at once, at some point, all assets are eventually served as 403. This causes denial of assets for all policies of Directus, including Admin and Public. Version 12.0.1 of the `@directus/storage-driver-s3` package, corresponding to version 11.5.0 of Directus, fixes the issue.