Описание
NiceGUI's XSS vulnerability in ui.markdown() allows arbitrary JavaScript execution through unsanitized HTML content
Description
The ui.markdown() component uses the markdown2 library to convert markdown content to HTML, which is then rendered via innerHTML. By default, markdown2 allows raw HTML to pass through unchanged. This means that if an application renders user-controlled content through ui.markdown(), an attacker can inject malicious HTML containing JavaScript event handlers.
Unlike other NiceGUI components that render HTML (ui.html(), ui.chat_message(), ui.interactive_image()), the ui.markdown() component does not provide or require a sanitize parameter, leaving applications vulnerable to XSS attacks.
Proof of Concept
When this page loads, the JavaScript in the onerror handler executes, potentially allowing an attacker to:
- Steal session cookies or authentication tokens
- Perform actions on behalf of the user
- Redirect users to malicious sites
- Modify page content
Impact
Applications that render user-provided content through ui.markdown() are vulnerable to stored or reflected XSS attacks. This is particularly concerning for:
- Chat applications displaying user messages
- CMS or documentation systems with user-editable content
- Any application that displays markdown from untrusted sources
Remediation
A release has been published in version 3.7.0.
For Users (Immediate Workaround)
Until a fix is released, do not pass untrusted content directly to ui.markdown(). Instead, use one of these approaches:
Option 1: Convert and sanitize manually using ui.html()
Option 2: Escape HTML before markdown conversion (if raw HTML not needed)
Proposed Fix
Add a sanitize parameter to ui.markdown() consistent with other HTML-rendering components, and/or add an escape_html parameter.
Пакеты
nicegui
<= 3.6.1
3.7.0