Описание
Vyper's nonpayable default functions are sometimes payable
Impact
in contracts with at least one regular nonpayable function, due to the callvalue check being inside of the selector section, it is possible to send funds to the default function by using less than 4 bytes of calldata, even if the default function is marked nonpayable. this applies to contracts compiled with vyper<=0.3.7.
Patches
this was fixed by the removal of the global calldatasize check in https://github.com/vyperlang/vyper/commit/02339dfda0f3caabad142060d511d10bfe93c520.
Workarounds
don't use nonpayable default functions
Ссылки
- https://github.com/vyperlang/vyper/security/advisories/GHSA-vxmm-cwh2-q762
- https://nvd.nist.gov/vuln/detail/CVE-2023-32675
- https://github.com/vyperlang/vyper/commit/02339dfda0f3caabad142060d511d10bfe93c520
- https://github.com/vyperlang/vyper/commit/02339dfda0f3caabad142060d511d10bfe93c520.
- https://github.com/vyperlang/vyper/commit/903727006c1e5ebef99fa9fd5d51d62bd33d72a9
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-80.yaml
Пакеты
vyper
< 0.3.8
0.3.8
Связанные уязвимости
Vyper is a pythonic Smart Contract Language for the ethereum virtual machine. In contracts with more than one regular nonpayable function, it is possible to send funds to the default function, even if the default function is marked `nonpayable`. This applies to contracts compiled with vyper versions prior to 0.3.8. This issue was fixed by the removal of the global `calldatasize` check in commit `02339dfda`. Users are advised to upgrade to version 0.3.8. Users unable to upgrade should avoid use of nonpayable default functions.