Описание
Malicious Long Unicode filenames may cause a Multiple Application-level Denial of Service
Important: Exploiting this vulnerability requires the attacker to have access to your Frigate instance, which means they could also just delete all of your recordings or perform any other action. If you have configured authentication in front of Frigate via a reverse proxy, then this vulnerability is not exploitable without first getting around your authentication method. For many obvious reasons in addition to this one, please don't expose your Frigate instance publicly without any kind of authentication.
Summary
When uploading a file or retrieving the filename, a user may intentionally use a large Unicode filename which would lead to a application-level denial of service. This is due to no limitation set on the length of the filename and the costy use of the Unicode normalization with the form NFKD under the hood of secure_filename().
I idenfied multiple vulnerable paths on blakeblackshear/frigate repository. In all of those paths, it was possible for a malicious user to send a filename equals to the output of : python3 -c "print('℀' * 1_000_000)" which would reach the werkzeug secure_filename() call , which in turn under the hood uses a compatibility Unicode normalization with NFKC/NFKD form. In sum, the latter call would be costly in matter of CPU resource and may lead to the application-level denial of service.
Vulnerable Paths
Path with 2 steps
-
@MediaBp.route("/<camera_name>/start/<int:start_ts>/end/<int:end_ts>/clip.mp4") @MediaBp.route("/<camera_name>/start/<float:start_ts>/end/<float:end_ts>/clip.mp4") def recording_clip(camera_name, start_ts, end_ts): download = request.args.get("download", type=bool)
-
playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name)
playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}")
file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4")
path = os.path.join(CACHE_DIR, file_name)
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 2 steps
-
@MediaBp.route("/<camera_name>/start/<int:start_ts>/end/<int:end_ts>/clip.mp4") @MediaBp.route("/<camera_name>/start/<float:start_ts>/end/<float:end_ts>/clip.mp4") def recording_clip(camera_name, start_ts, end_ts): download = request.args.get("download", type=bool)
-
playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name)
playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}")
file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4")
path = os.path.join(CACHE_DIR, file_name)
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 2 steps
-
@MediaBp.route("/<camera_name>/start/<int:start_ts>/end/<int:end_ts>/clip.mp4") @MediaBp.route("/<camera_name>/start/<float:start_ts>/end/<float:end_ts>/clip.mp4") def recording_clip(camera_name, start_ts, end_ts): download = request.args.get("download", type=bool)
-
playlist_lines.append(f"outpoint {int(end_ts - clip.start_time)}") file_name = secure_filename(f"clip_{camera_name}_{start_ts}-{end_ts}.mp4") path = os.path.join(CACHE_DIR, file_name)
current_app.frigate_config,
camera_name,
secure_filename(name.replace(" ", "_")) if name else None,
int(start_time),
int(end_time),
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 8 steps
-
jsonify, make_response, request, ) from peewee import DoesNotExist, fn
-
jsonify, make_response, request, ) from peewee import DoesNotExist, fn
-
) json: dict[str, any] = request.get_json(silent=True) or {} playback_factor = json.get("playback", "realtime") name: Optional[str] = json.get("name")
-
) json: dict[str, any] = request.get_json(silent=True) or {} playback_factor = json.get("playback", "realtime") name: Optional[str] = json.get("name")
-
json: dict[str, any] = request.get_json(silent=True) or {} playback_factor = json.get("playback", "realtime") name: Optional[str] = json.get("name") recordings_count = (
-
json: dict[str, any] = request.get_json(silent=True) or {} playback_factor = json.get("playback", "realtime") name: Optional[str] = json.get("name") recordings_count = (
-
json: dict[str, any] = request.get_json(silent=True) or {} playback_factor = json.get("playback", "realtime") name: Optional[str] = json.get("name") recordings_count = (
-
current_app.frigate_config, camera_name, secure_filename(name.replace(" ", "_")) if name else None, int(start_time), int(end_time),
def export_rename(file_name_current, file_name_new: str):
safe_file_name_current = secure_filename(
export_filename_check_extension(file_name_current)
)
file_current = os.path.join(EXPORT_DIR, safe_file_name_current)
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 5 steps
-
@MediaBp.route("/export/<file_name_current>/<file_name_new>", methods=["PATCH"]) def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current)
-
def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current) ) file_current = os.path.join(EXPORT_DIR, safe_file_name_current)
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename else: return filename + ".mp4"
-
def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current) ) file_current = os.path.join(EXPORT_DIR, safe_file_name_current)
Path with 5 steps
-
@MediaBp.route("/export/<file_name_current>/<file_name_new>", methods=["PATCH"]) def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current)
-
def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current) ) file_current = os.path.join(EXPORT_DIR, safe_file_name_current)
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename
-
return filename else: return filename + ".mp4"
-
def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current) ) file_current = os.path.join(EXPORT_DIR, safe_file_name_current)
)
safe_file_name_new = secure_filename(export_filename_check_extension(file_name_new))
file_new = os.path.join(EXPORT_DIR, safe_file_name_new)
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 5 steps
-
@MediaBp.route("/export/<file_name_current>/<file_name_new>", methods=["PATCH"]) def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current)
-
) safe_file_name_new = secure_filename(export_filename_check_extension(file_name_new)) file_new = os.path.join(EXPORT_DIR, safe_file_name_new)
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename else: return filename + ".mp4"
-
) safe_file_name_new = secure_filename(export_filename_check_extension(file_name_new)) file_new = os.path.join(EXPORT_DIR, safe_file_name_new)
Path with 5 steps
-
@MediaBp.route("/export/<file_name_current>/<file_name_new>", methods=["PATCH"]) def export_rename(file_name_current, file_name_new: str): safe_file_name_current = secure_filename( export_filename_check_extension(file_name_current)
-
) safe_file_name_new = secure_filename(export_filename_check_extension(file_name_new)) file_new = os.path.join(EXPORT_DIR, safe_file_name_new)
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename
-
return filename else: return filename + ".mp4"
-
) safe_file_name_new = secure_filename(export_filename_check_extension(file_name_new)) file_new = os.path.join(EXPORT_DIR, safe_file_name_new)
@MediaBp.route("/export/<file_name>", methods=["DELETE"])
def export_delete(file_name: str):
safe_file_name = secure_filename(export_filename_check_extension(file_name))
file = os.path.join(EXPORT_DIR, safe_file_name)
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 5 steps
-
@MediaBp.route("/export/<file_name>", methods=["DELETE"]) def export_delete(file_name: str): safe_file_name = secure_filename(export_filename_check_extension(file_name)) file = os.path.join(EXPORT_DIR, safe_file_name)
-
@MediaBp.route("/export/<file_name>", methods=["DELETE"]) def export_delete(file_name: str): safe_file_name = secure_filename(export_filename_check_extension(file_name)) file = os.path.join(EXPORT_DIR, safe_file_name)
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename else: return filename + ".mp4"
-
@MediaBp.route("/export/<file_name>", methods=["DELETE"]) def export_delete(file_name: str): safe_file_name = secure_filename(export_filename_check_extension(file_name)) file = os.path.join(EXPORT_DIR, safe_file_name)
Path with 5 steps
-
@MediaBp.route("/export/<file_name>", methods=["DELETE"]) def export_delete(file_name: str): safe_file_name = secure_filename(export_filename_check_extension(file_name)) file = os.path.join(EXPORT_DIR, safe_file_name)
-
@MediaBp.route("/export/<file_name>", methods=["DELETE"]) def export_delete(file_name: str): safe_file_name = secure_filename(export_filename_check_extension(file_name)) file = os.path.join(EXPORT_DIR, safe_file_name)
-
def export_filename_check_extension(filename: str): if filename.endswith(".mp4"): return filename
-
return filename else: return filename + ".mp4"
-
@MediaBp.route("/export/<file_name>", methods=["DELETE"]) def export_delete(file_name: str): safe_file_name = secure_filename(export_filename_check_extension(file_name)) file = os.path.join(EXPORT_DIR, safe_file_name)
def preview_thumbnail(file_name: str):
"""Get a thumbnail from the cached preview frames."""
safe_file_name_current = secure_filename(file_name)
preview_dir = os.path.join(CACHE_DIR, "preview_frames")
This user-provided value can reach a costly Unicode normalization operation.
Paths
Path with 2 steps
-
@MediaBp.route("/preview/<file_name>/thumbnail.jpg") @MediaBp.route("/preview/<file_name>/thumbnail.webp") def preview_thumbnail(file_name: str): """Get a thumbnail from the cached preview frames.""" safe_file_name_current = secure_filename(file_name)
-
def preview_thumbnail(file_name: str): """Get a thumbnail from the cached preview frames.""" safe_file_name_current = secure_filename(file_name) preview_dir = os.path.join(CACHE_DIR, "preview_frames")
Impact
- Application-level Denial of Service, the web app would hung undefinetly and not process any further request due to the use of the malicious payload.
Mitigation
- Limiting the length of the incoming filename, similar to this commit fix.
References
- Similar to CVE-2023-46695
Ссылки
- https://github.com/blakeblackshear/frigate/security/advisories/GHSA-w4h6-9wrp-v5jq
- https://nvd.nist.gov/vuln/detail/CVE-2024-32874
- https://github.com/blakeblackshear/frigate/commit/cc851555e4029647986dccc8b8ecf54afee31442
- https://github.com/blakeblackshear/frigate/blob/d7ae0eedf89e14f297093ac5c8042862034cbaeb/frigate/api/media.py#L1346C46-L1346C55
- https://github.com/blakeblackshear/frigate/blob/d7ae0eedf89e14f297093ac5c8042862034cbaeb/frigate/api/media.py#L408C33-L408C78
- https://github.com/blakeblackshear/frigate/blob/d7ae0eedf89e14f297093ac5c8042862034cbaeb/frigate/api/media.py#L646C25-L646C47
- https://github.com/blakeblackshear/frigate/blob/d7ae0eedf89e14f297093ac5c8042862034cbaeb/frigate/api/media.py#L684C9-L684C59
- https://github.com/blakeblackshear/frigate/blob/d7ae0eedf89e14f297093ac5c8042862034cbaeb/frigate/api/media.py#L705C42-L705C88
- https://github.com/blakeblackshear/frigate/blob/d7ae0eedf89e14f297093ac5c8042862034cbaeb/frigate/api/media.py#L728C38-L728C80
Пакеты
Наименование
frigate
pip
Затронутые версииВерсия исправления
< 0.13.2
0.13.2
Связанные уязвимости
CVSS3: 6.8
nvd
больше 1 года назад
Frigate is a network video recorder (NVR) with realtime local object detection for IP cameras. Below 0.13.2 Release, when uploading a file or retrieving the filename, a user may intentionally use a large Unicode filename which would lead to a application-level denial of service. This is due to no limitation set on the length of the filename and the costy use of the Unicode normalization with the form NFKD under the hood of `secure_filename()`.